| Age | Commit message (Collapse) | Author |
|---|
|
When autocompleting from `pass <TAB>', sometimes the following errors
appear:
_values:compvalues:10: not enough arguments
find: `/home/user/.password-store': No such file or directory
_values:compvalues:10: not enough arguments
find: `/home/user/.password-store': No such file or directory
The `_values' error happens when there is no password-store folder *or*
there are no passwords in pass; the `find' error only when there is no
password-store folder.
We can trace it back to line 108, which contains the only `_values'
statement that is executed when we autocomplete from pass. We confirm
this by following the trail of execution, which is
_pass -> _pass_cmd_show -> _pass_complete_entries ->
-> _pass_complete_entries_helper
If we try running the command inside `$()' on line 104, we see that it
returns nothing and the output is blank. This means that `_values' only
receives 1 of its 2 mandatory parameters, therefore the above error is
triggered (not enough arguments).
That is unless we don't have a password-store folder, in which case the
`find: [...] no such file or directory' error is *also* triggered.
We solve the first error by supplying a default value of "" if the
command outputs nothing, using the zsh construct ${var:-else}.
We solve the second error by redirecting the find command's stderr output
to /dev/null, so the error is effectively suppressed.
* * * *
This patch also fixes the first tab completion, which currently only
loads the completion function definition.
We do this by adding a `_pass' statement at the end of the file, which
runs the `_pass' completion function after loading its definition.
This is the standard way an autoloaded function works; for other examples
look at zsh's official completion files.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In the move away from extensive global variables and improved cleanup
routines, we forgot to fix the darwin platform file, which means
temporary ramdisks never got unmounted. This patch cleans up the general
cleanup trap logic routines.
|
|
This is required by most graphical editors, as the shell command they
provide needs to be told to wait until the file has been closed.
This reverts '311c98c9140205f32be2720db9261c67da658c4c'. We thus use
PATH so that the tests still pass in directories with spaces.
|
|
|
|
|
|
|
|
Key discovery parses stderr output of gnupg. The secmem warning
interferes with parsing.
|
|
|
|
|
|
|
|
- usefull for git commands showing diff, e.g.: pass git log -p
- from what I can see, not 'cleartext' temporary files are created
|
|
|
|
|
|
|
|
Revert "Mute git-commit messages to make pass insert readable"
This reverts commit f30ce6374d554e704162d5fa8e49acd9c6fd0ecc.
I decided I like the git output. Instead highlight generated passwords
using nice terminal output instead.
|
|
This reverts commit 56381287a16792b4c6410f07db68e02f3574c213, and
further fixes things.
|
|
|
|
|
|
`pass generate' prints 10 lines of output, with only 2 related
to the operation at hand:
% pass generate xyz
1
2 You need a passphrase to unlock the secret key for
3 user: USER <EMAIL>
4 4096-bit RSA key, ID XYZ, created 1234-56-78
5
6 [master 12345] Added generated password for xyz to store.
7 1 file changed, 0 insertions(+), 0 deletions(-)
8 create mode 100644 xyz.gpg
9 The generated password to xyz is:
10 Some password 123
%
This patch takes care of 3 of 8 noise lines.
|
|
Made sed expression GNU and BSD compatible.
A recent change in pass.zsh-completion broke autocompletion when using
BSD sed. I’ve made the relevant sed expression compatible with GNU and
BSD sed.
Previous change with regression:
http://lists.zx2c4.com/pipermail/password-store/2014-April/000773.html
http://git.zx2c4.com/password-store/commit/src/completion/pass.zsh-completion?id=f82e9d6cf3bc3a12bdfce89bf319d76f79e66efc
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|