m-chrzan.xyz
aboutsummaryrefslogtreecommitdiff
path: root/src/test/java/pl/edu/mimuw/cloudatlas/agent
diff options
context:
space:
mode:
authorMagdalena GrodziƄska <mag.grodzinska@gmail.com>2020-01-14 23:05:06 +0100
committerGitHub <noreply@github.com>2020-01-14 23:05:06 +0100
commit7972afc9cab164615116f494e6824b88f8f873a7 (patch)
treec1ac0ebff3d5e980d85e841de75aacbe891b8f37 /src/test/java/pl/edu/mimuw/cloudatlas/agent
parent47ff68f0535f90eb4b09cb8c9c88555abd900cc8 (diff)
parent42b9d84b2668476510d015b40510fa18a0cffbdd (diff)
Merge pull request #120 from m-chrzan/final_fixes
Remove TODOs
Diffstat (limited to 'src/test/java/pl/edu/mimuw/cloudatlas/agent')
-rw-r--r--src/test/java/pl/edu/mimuw/cloudatlas/agent/AgentIntegrationTest.java2
-rw-r--r--src/test/java/pl/edu/mimuw/cloudatlas/agent/EventBusTest.java3
-rw-r--r--src/test/java/pl/edu/mimuw/cloudatlas/agent/ExecutorTest.java2
-rw-r--r--src/test/java/pl/edu/mimuw/cloudatlas/agent/SchedulerTest.java3
-rw-r--r--src/test/java/pl/edu/mimuw/cloudatlas/agent/UDUPTest.java2
5 files changed, 0 insertions, 12 deletions
diff --git a/src/test/java/pl/edu/mimuw/cloudatlas/agent/AgentIntegrationTest.java b/src/test/java/pl/edu/mimuw/cloudatlas/agent/AgentIntegrationTest.java
index 26473cd..6d220e8 100644
--- a/src/test/java/pl/edu/mimuw/cloudatlas/agent/AgentIntegrationTest.java
+++ b/src/test/java/pl/edu/mimuw/cloudatlas/agent/AgentIntegrationTest.java
@@ -115,7 +115,6 @@ public class AgentIntegrationTest {
// String name = "&query";
// String queryCode = "SELECT 1 AS one";
// api.installQuery(name, queryCode);
-// // TODO: test something here
// }
// @Test
@@ -137,7 +136,6 @@ public class AgentIntegrationTest {
// api.uninstallQuery(name);
// AttributesMap attributes = api.getZoneAttributeValues("/pjwstk");
// assertNull(attributes.getOrNull(name));
-// // TODO: test this correctly
// }
@Test
diff --git a/src/test/java/pl/edu/mimuw/cloudatlas/agent/EventBusTest.java b/src/test/java/pl/edu/mimuw/cloudatlas/agent/EventBusTest.java
index 34b80bb..dfd69cc 100644
--- a/src/test/java/pl/edu/mimuw/cloudatlas/agent/EventBusTest.java
+++ b/src/test/java/pl/edu/mimuw/cloudatlas/agent/EventBusTest.java
@@ -31,7 +31,6 @@ public class EventBusTest {
@Override
public void handle(AgentMessage event) throws InterruptedException {
System.out.println("Module 1 handle called");
- // TODO correct message subclass
sendMessage(new AgentMessage("1", ModuleType.UDP) {});
counter ++;
}
@@ -64,7 +63,6 @@ public class EventBusTest {
@Test
@Ignore
- // TODO correct message subclass
public void messageModule() throws InterruptedException {
HashMap<ModuleType, Module> modules = initializeModule();
HashMap<ModuleType, Executor> executors = Agent.initializeExecutors(modules);
@@ -82,7 +80,6 @@ public class EventBusTest {
@Test
@Ignore
- // TODO correct message subclass
public void messagingBetweenModules() throws InterruptedException {
HashMap<ModuleType, Module> modules = initializeTwoModules();
HashMap<ModuleType, Executor> executors = Agent.initializeExecutors(modules);
diff --git a/src/test/java/pl/edu/mimuw/cloudatlas/agent/ExecutorTest.java b/src/test/java/pl/edu/mimuw/cloudatlas/agent/ExecutorTest.java
index 2898d3c..501bca5 100644
--- a/src/test/java/pl/edu/mimuw/cloudatlas/agent/ExecutorTest.java
+++ b/src/test/java/pl/edu/mimuw/cloudatlas/agent/ExecutorTest.java
@@ -8,8 +8,6 @@ import pl.edu.mimuw.cloudatlas.agent.messages.ResponseMessage;
import pl.edu.mimuw.cloudatlas.agent.modules.Module;
import pl.edu.mimuw.cloudatlas.agent.modules.ModuleType;
-// TODO make agent messages specific subclass
-
public class ExecutorTest {
public class MessageCounterModule extends Module {
public int counter = 0;
diff --git a/src/test/java/pl/edu/mimuw/cloudatlas/agent/SchedulerTest.java b/src/test/java/pl/edu/mimuw/cloudatlas/agent/SchedulerTest.java
index 99051ff..a0948f7 100644
--- a/src/test/java/pl/edu/mimuw/cloudatlas/agent/SchedulerTest.java
+++ b/src/test/java/pl/edu/mimuw/cloudatlas/agent/SchedulerTest.java
@@ -11,9 +11,6 @@ import pl.edu.mimuw.cloudatlas.agent.modules.TimerScheduler;
import java.util.ArrayList;
import java.util.HashMap;
-// TODO better task tests with counters after enabling messaging from tasks
-// TODO add wrong message test with switched types
-
public class SchedulerTest {
private HashMap<ModuleType, Module> modules;
private HashMap<ModuleType, Executor> executors;
diff --git a/src/test/java/pl/edu/mimuw/cloudatlas/agent/UDUPTest.java b/src/test/java/pl/edu/mimuw/cloudatlas/agent/UDUPTest.java
index 922ebe2..4f32d89 100644
--- a/src/test/java/pl/edu/mimuw/cloudatlas/agent/UDUPTest.java
+++ b/src/test/java/pl/edu/mimuw/cloudatlas/agent/UDUPTest.java
@@ -18,8 +18,6 @@ import java.net.InetAddress;
import java.net.SocketException;
import java.net.UnknownHostException;
-// TODO add serialization tests that target custom serializers (type collections!)
-
@Ignore
public class UDUPTest {