diff options
| author | Ayush Agarwal <ayush@fastmail.in> | 2021-09-15 22:47:27 +0530 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-09-23 15:25:28 -0600 |
| commit | a80a3189458a86f29f61d980b4ad977594199864 (patch) | |
| tree | b2473c0fb7b5498c2a32355b9de369391aa1b192 /src/completion | |
| parent | 85bb62f47ac2f518bfdb36c5dfedf5938219a9b7 (diff) | |
Replace 'which' with POSIX equivalent 'command -v'
The 'which' command is an external command that must be called each and
every time pass is used. 'which' is also not mentioned in the README as
one of the dependencies that might be needed to run pass.
Instead of 'which', we can use the POSIX compatible and shell built-in
'command -v'. It saves pass from making an external call and is,
arguably, more reliable than using 'which' as mentioned in the following
link.
Diffstat (limited to 'src/completion')
| -rw-r--r-- | src/completion/pass.bash-completion | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/completion/pass.bash-completion b/src/completion/pass.bash-completion index 95d3e1e..2d23cbf 100644 --- a/src/completion/pass.bash-completion +++ b/src/completion/pass.bash-completion @@ -72,7 +72,7 @@ _pass_complete_folders () { _pass_complete_keys () { local GPG="gpg" - which gpg2 &>/dev/null && GPG="gpg2" + command -v gpg2 &>/dev/null && GPG="gpg2" local IFS=$'\n' # Extract names and email addresses from gpg --list-keys |